Skip table fallback when coloring by element DataFrame column#571
Merged
Skip table fallback when coloring by element DataFrame column#571
Conversation
When `_locate_value` determines the color column lives on the element's own DataFrame (origin="df"), skip the table lookup entirely. This avoids a spurious "No table name provided, using X as fallback" warning when multiple tables exist but the color data doesn't come from any of them. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Remove redundant len(origins) == 1 guard (already inside that branch) - Pass table_to_use (not table_name) to _has_colors_in_uns and _extract_colors_from_table_uns so that element-origin values don't accidentally pick up .uns colors from an unrelated table Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #571 +/- ##
==========================================
- Coverage 75.61% 75.19% -0.43%
==========================================
Files 10 10
Lines 2908 2911 +3
Branches 672 673 +1
==========================================
- Hits 2199 2189 -10
- Misses 428 443 +15
+ Partials 281 279 -2
🚀 New features to boost your workflow:
|
When no table is resolved (element-origin, no tables, or user-specified table not found), skip the .uns color lookup entirely rather than scanning all tables with table_name=None. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_locate_valuedetermines the color column lives on the element (origin="df"), the table lookup for.unscolors is now skipped entirely